Skip to content

Respect --program-prefix and --program-suffix when installing phar #5650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

n8man
Copy link
Contributor

@n8man n8man commented May 30, 2020

Currently ./configure --enable-phar --program-suffix=7.4 will result in files named php7.4 and phar

This change would instead result in files named php7.4 and phar7.4

This improves consistency and improves the ability to maintain clearly separate binary names in multi-version environments

Currently ./configure --enable-phar --program-suffix=7.4 will result in binaries named php7.4 and phar but should instead result in php7.4 and phar7.4
@n8man
Copy link
Contributor Author

n8man commented May 30, 2020

This PR also applies the program_suffix to phar.phar such that a suffix of 7.4 results in phar.phar7.4. This is similar to the way that I've seen deb/apt-based distros package phar but is odd in that it does confuse the meaning of the .phar file extension.

An alternative would be to apply the program_suffix such that the resultant filename of phar.phar is phar7.4.phar, preserving the .phar file extension, instead of phar.phar7.4

@nikic
Copy link
Member

nikic commented May 31, 2020

This PR also applies the program_suffix to phar.phar such that a suffix of 7.4 results in phar.phar7.4. This is similar to the way that I've seen deb/apt-based distros package phar but is odd in that it does confuse the meaning of the .phar file extension.

An alternative would be to apply the program_suffix such that the resultant filename of phar.phar is phar7.4.phar, preserving the .phar file extension, instead of phar.phar7.4

I think your alternative suggestion makes more sense, it should be phar7.4.phar. I wonder if you also need to add the suffix to the man page files?

Also cc @remicollet, I'm not sure what assumptions are in place here.

@n8man
Copy link
Contributor Author

n8man commented May 31, 2020

@nikic I've implemented phar$(program_suffix).phar. You're right about the man page files. I've now added the suffix to the phar man page files

@n8man n8man changed the title Respect --program-suffix when installing phar Respect --program-prefix and --program-suffix when installing phar Jun 2, 2020
@n8man
Copy link
Contributor Author

n8man commented Jun 2, 2020

--program-prefix and --program-suffix are now both applied to phar and phar.phar and their man page paths in essentially the same way that they are for php, phpdbg, php-config, and phpize binaries

@php-pulls php-pulls closed this in ca7dcb8 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants